Skip to content

Auto-increment job name when adaptor already used in workflow#4463

Merged
taylordowns2000 merged 2 commits intomainfrom
claude/fix-issue-OwcjW
Feb 25, 2026
Merged

Auto-increment job name when adaptor already used in workflow#4463
taylordowns2000 merged 2 commits intomainfrom
claude/fix-issue-OwcjW

Conversation

@brandonjackson
Copy link
Copy Markdown
Contributor

@brandonjackson brandonjackson commented Feb 25, 2026

Description

This PR fixes duplicate job names when adding multiple jobs with the same adaptor. When adding a new job node with an adaptor that already has a job using the same display name, append an incrementing number to make the name unique (e.g. "Whatsapp" → "Whatsapp 1" → "Whatsapp 2"). This prevents the "Job name should be distinct" save error.

Closes #4464

Validation steps

  1. Open a workflow and add a job with e.g. the Whatsapp adaptor
  2. Add another job with the same adaptor
  3. Verify the second job is named "Whatsapp 1" instead of "Whatsapp"
  4. Add a third — verify it's named "Whatsapp 2"

Additional notes for the reviewer

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

When adding a new job node with an adaptor that already has a job
using the same display name, append an incrementing number to make
the name unique (e.g. "Whatsapp" → "Whatsapp 1" → "Whatsapp 2").
This prevents the "Job name should be distinct" save error.

https://claude.ai/code/session_012J16P3QNdRrMLbzACMQ8fa
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (b4da2cf) to head (7dde0bf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4463   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files         425      425           
  Lines       20212    20212           
=======================================
+ Hits        18079    18081    +2     
+ Misses       2133     2131    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @brandonjackson 👏🏽

@elias-ba
Copy link
Copy Markdown
Contributor

elias-ba commented Feb 25, 2026

Hey @brandonjackson, thank you very much for this PR; this is really great! The code is clean and handles edge cases well. I went ahead and tidied up a few things:

  • Created an issue (#4464) and linked it to this PR
  • Added a changelog entry under [Unreleased] > Fixed
  • Updated the PR description to match our PR template. A tip for next time: you can instruct Claude Code to always use the template in .github/ when opening PRs, saves a step!
  • Added Taylor as a second reviewer; we have a two-review rule before merging to main

Everything else looks good to go. Thanks again!

@taylordowns2000 taylordowns2000 merged commit e7c8d51 into main Feb 25, 2026
7 checks passed
@taylordowns2000 taylordowns2000 deleted the claude/fix-issue-OwcjW branch February 25, 2026 15:19
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Duplicate job name error when adding multiple jobs with same adaptor

4 participants