Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4478 +/- ##
==========================================
+ Coverage 89.43% 89.48% +0.05%
==========================================
Files 425 425
Lines 20253 20303 +50
==========================================
+ Hits 18113 18169 +56
+ Misses 2140 2134 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
midigofrank
approved these changes
Mar 5, 2026
Collaborator
There was a problem hiding this comment.
Nicely done @doc-han . This will definitely improve the loading times. Can we do a follow up issue that uses async_assigns to load the stats? https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.html#module-async-assigns
---EDIT---
I have created it here: #4489
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimises the db query on the workflows list page. instead of doing 5 queries per workflow on the page. we collect the workflow ids and do a single batch query per group.
Closes #3675
Closes #2426
Validation steps
Non technical
Technical
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)