Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
==========================================
+ Coverage 89.55% 89.66% +0.10%
==========================================
Files 425 426 +1
Lines 20344 20323 -21
==========================================
+ Hits 18220 18222 +2
+ Misses 2124 2101 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Bump phoenix ~> 1.8, phoenix_live_view ~> 1.1, y_ex ~> 0.10.2, oban ~> 2.20, phoenix_storybook ~> 1.0, mix_test_watch ~> 1.4 - Add lazy_html test dependency (required by LiveView 1.1) - Add :phoenix_live_view compiler to mix.exs compilers list - Migrate ErrorView to format-specific ErrorHTML and ErrorJSON modules to match Phoenix 1.7+ conventions; update render_errors config and all put_view call sites across controllers and plugs - Remove dead live routes for SettingsLive.Index and JobLive.Index that LiveView 1.1 now validates at compile time
Phoenix 1.8 renders boolean HTML attributes as attr="" instead of
attr="attr". lazy_html (new LiveView 1.1 test dep) enforces stricter
CSS selector parsing than Floki. Changes:
- Replace disabled="disabled" / checked="checked" assertions with
disabled="" / checked="" throughout
- Replace [attr='attr'] CSS selectors with presence-only [attr] selectors
- Fix malformed attribute selectors missing closing quotes that Floki
accepted silently but lazy_html rejects (e.g. [id='...id])
- Fix comma-separated attributes in single brackets to chained brackets
(e.g. [a='x', b='y'] -> [a='x'][b='y'])
- Replace tbody:first-child selectors (now semantically enforced by
lazy_html) with tbody:first-of-type or scoped ID selectors
- Replace selected="selected" option assertions with selected=""
- Fix save_is_disabled? helper to use List.keymember? instead of
checking for {"disabled", "disabled"} tuple
- Replace ErrorViewTest with tests for ErrorHTML and ErrorJSON,
including integration tests that exercise the full request cycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade phoenix and other deps
Closes #4338
Closes #4337
Closes #4336
Closes #4335
Closes #4334
Closes #4303
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)