Consider manual runs when determining next run input#4585
Merged
theroinaochieng merged 1 commit intomainfrom Mar 31, 2026
Merged
Consider manual runs when determining next run input#4585theroinaochieng merged 1 commit intomainfrom
theroinaochieng merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4585 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 441 441
Lines 21207 21207
=======================================
Hits 18986 18986
Misses 2221 2221 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theroinaochieng
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #4584 .
Cron-triggered workflow runs were ignoring manual run outputs when determining the next input state.
last_run_final_dataclip/1filtered bywo.trigger_id, which excluded manual runs (whose work orders havetrigger_id = nil).Changed the filter to scope by
wo.workflow_idinstead, so the most recent successful run is used regardless of how it was triggered. While you could argue that we shouldn't consider manual runs when calculating the next input state for a scheduled run, this isn't how we do it when using the "single step" option, so we should keep it the same for "Final run state" option.Validation steps
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)