Don't redirect to runs page after clicking run#4608
Conversation
| } else { | ||
| // Fallback: navigate away if no callback (for standalone mode) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${response.data.run_id}`; |
There was a problem hiding this comment.
this is the change - don't redirect away from the canvas!
| } else { | ||
| // Fallback: navigate to new run (component will unmount) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${result.data.run_id}`; |
There was a problem hiding this comment.
same here - don't redirect!
Security ReviewClaude hit the max-turns limit or encountered an error before posting findings. See the workflow run for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4608 +/- ##
==========================================
- Coverage 89.59% 89.57% -0.02%
==========================================
Files 444 444
Lines 21558 21558
==========================================
- Hits 19314 19311 -3
- Misses 2244 2247 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@taylordowns2000 I don't understand this concern. |
Description
This PR fixes the workflow canvas to stay on the page after clicking "Run" or "Retry" instead of redirecting to the history page. It also tracks the run ID in the URL (?run=...) so the run selection persists, adds a fallback to the history store's active run when LiveView strips the client-side URL param, and gives in-progress steps a blue highlight on the canvas (matching the "running" chip color in the mini history panel).
Closes #4198
Validation steps
Additional notes for the reviewer
isRetryingRefbug was a missing reset in the else branch (canvas flow) ofhandleRetry— theonRunSubmittedpath reset it via thependingRunIdeffect, but the no-callback path never did.styles.test.ts(node colors),CollaborativeWorkflowDiagram.url-fallback.test.tsx(URL resilience), plus 4 new tests inuseRunRetry.test.tsx(canvas flow + regression).AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)