Open
Conversation
Security ReviewClaude hit the max-turns limit or encountered an error before posting findings. See the workflow run for details. |
f8eabbf to
a087e56
Compare
5352b58 to
2013482
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4612 +/- ##
=======================================
Coverage 89.61% 89.62%
=======================================
Files 444 443 -1
Lines 21505 21494 -11
=======================================
- Hits 19272 19264 -8
+ Misses 2233 2230 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2013482 to
f70a044
Compare
ee4de55 to
df56201
Compare
Redesign the project picker to show sandbox hierarchy and remove global sandbox theming from the sidebar/navbar. - Project picker button shows parent:child format with sandbox accent color and beaker icon, chevron-down dropdown indicator - Project picker overlay lists sandboxes as nested children under their parent project with tree indentation at any depth - Remove sandbox color theming from sidebar/navbar - only the picker button shows the accent color - Unify ProjectPickerButton as single React component used by both HEEx layouts and the collaborative editor - Unify global_project_picker as shared layout component - Navigation preserves current section when switching projects - Remove dead ProjectTheme module and theme preview code - Clean up stale CSS selectors
df56201 to
8800cca
Compare
theroinaochieng
approved these changes
Apr 14, 2026
Collaborator
theroinaochieng
left a comment
There was a problem hiding this comment.
Hey Elias, this looks really good. Great job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you're inside a sandbox, the project picker now shows both the parent project and sandbox name (e.g.
ethiopia-bdr:feb-red-team) instead of just the sandbox name. The button gets the sandbox accent color and a beaker icon so you can tell at a glance that you're in a sandbox.The sidebar and navbar no longer change color when you're in a sandbox. The accent color only lives on the picker button itself.
Inside the picker overlay, sandboxes show up as indented children under their parent project, with support for arbitrary nesting depth. Searching works across the full hierarchy path.
I also consolidated things: the picker button is now a single React component (
ProjectPickerButton) shared between the standard HEEx pages and the collaborative editor, and the picker overlay is a singleglobal_project_pickercomponent shared across all layouts. The oldProjectThememodule and theme preview code were no longer needed so I removed them.Closes #4510
Validation steps
AI Usage
Pre-submission checklist
/reviewwith Claude Code)