Conversation
Problems
|
|
@josephjclark suggests we keep v1 as default and then allow users to switch to v2 style |
|
Sample v2 filesystem after sync has been established: https://github.com/doc-han/openfn-new |
3a3bd93 to
bee2f38
Compare
bee2f38 to
157de85
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4634 +/- ##
==========================================
+ Coverage 89.62% 89.67% +0.05%
==========================================
Files 444 444
Lines 21609 21627 +18
==========================================
+ Hits 19366 19395 +29
+ Misses 2243 2232 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
midigofrank
left a comment
There was a problem hiding this comment.
Nicely done @doc-han , left a few change requests. Also, is there a link we can add that describes what this new yaml format is all about? Maybe community post or just the docs
Security ReviewSee the workflow run for the raw Claude output. |
josephjclark
left a comment
There was a problem hiding this comment.
Great @doc-han, I'm happy with this
I think we should run careful testing against staging. I've not done any kind of QA beyond watching you screen. It's not actually that complicated though so we should be alright
|
QA notes:
|
Description
This PR makes sync v2 protocol an option for syncing projects with Github. By default sync will use the old
config.jsonstyle but users can switch to the newopenfn.yamlstyle if they prefer.Currently defaults to v1 (legacy) but can be switched to v2 (new) style
Closes #4523
Validation steps
openfn.yamlformatopenfn.yamlis in github with nicely generated content like the example belowExample
openfn.yamlcontentAI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)