fix: ensure theme codes are indexed correctly in commands#149
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes potential array indexing issues in theme-related console commands by ensuring theme code arrays always have sequential numeric indexes when passed to Laravel Prompts search components.
Changes:
- Wrapped
array_mapcalls witharray_valuesinBuildCommand,CleanCommand, andTokensCommandto guarantee zero-based sequential indexes for the$optionsarray used in interactive search prompts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Console/Command/Theme/BuildCommand.php | Added array_values() wrap around theme code mapping for MultiSearchPrompt options |
| src/Console/Command/Theme/CleanCommand.php | Added array_values() wrap around theme code mapping for MultiSearchPrompt options |
| src/Console/Command/Theme/TokensCommand.php | Added array_values() wrap around theme code mapping for SearchPrompt options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important adjustment to how theme codes are collected and indexed in several theme-related console commands. The change ensures that the arrays of theme codes always have sequential numeric indexes, which can prevent potential issues with array handling in downstream logic.
The main change is:
$optionsarray inBuildCommand.php,CleanCommand.php, andTokensCommand.phpby wrapping thearray_mapcall witharray_values, ensuring that theme code arrays use zero-based sequential indexes. [1] [2] [3]