-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add MageForge Toolbar with basic audits #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
9b22d8f
feat: add MageForge Toolbar with basic audits
dermatz 2ad540d
feat: add new audits for images without dimensions, lazy load, and in…
dermatz f4f53c7
style: update SVG icons for various audits in MageForge Toolbar
dermatz afa647c
feat: add toggle all functionality and enable inspector by default
dermatz cc13366
feat: enhance image audits to exclude hidden elements
dermatz 0a1340c
feat: add inspector button to toolbar and remove unused inspector code
dermatz a1b75da
feat: add credit section to toolbar menu with link to MageForge
dermatz 1d74367
feat: add toggle background colors and update font size in toolbar
dermatz fdee826
fix: improve note formatting for disabled inspector message
dermatz c0ff71e
fix: handle outside click event for toolbar menu closure
dermatz ef97edb
feat: enhance inspector functionality with event handlers and caching
dermatz 4e19646
refactor: remove inspector button creation from toolbar UI
dermatz 53d3761
feat: update audit run methods to accept active state parameter
dermatz c0fbd64
feat: implement collapsible menu groups in toolbar UI
dermatz 55f4597
feat: update toolbar burger label to include 'MageForge'
dermatz 757ce34
[CodeFactor] Apply fixes to commit 55f4597
code-factor aa3fe38
feat: add option to show/hide button labels in toolbar settings
dermatz 0949924
style: update description for images without alt attributes
dermatz b5380ed
fix: update color parsing to use a sentinel value for transparency check
dermatz b8d8ab9
fix: improve aria-labelledby check for inputs without labels
dermatz f6f4131
fix: ensure overlay re-renders for live DOM changes on resize/scroll
dermatz 676eaa5
fix: re-initialize skipped mageforgeToolbar elements on Alpine init
dermatz 71d8fcf
refactor: remove toggle inspector event handler from MageForge Inspector
dermatz 2bab38d
feat: persist collapsed groups state in localStorage
dermatz 36fb32e
refactor: simplify inspector button attachment logic in toolbar
dermatz 5c3adb6
fix: handle potential errors when retrieving collapsed groups from lo…
dermatz f4375cc
feat: add aria-pressed attribute for menu item accessibility
dermatz 03ee45a
fix: correct opacity check for image visibility in audit
dermatz 0a28d34
docs: add third-party library credits to README
dermatz 6316a09
fix: handle potential null value for aria-labelledby text content
dermatz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /** | ||
| * MageForge Toolbar Audit – Tab Order | ||
| * | ||
| * Injected on-demand by the tab-order audit. | ||
| * Relies on CSS custom properties defined in toolbar.css :root. | ||
| */ | ||
|
|
||
| .mageforge-tab-order-overlay { | ||
| position: fixed; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| pointer-events: none; | ||
| z-index: 9999997; | ||
| overflow: visible; | ||
| } | ||
|
|
||
| .mageforge-tab-order-svg { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| overflow: visible; | ||
| } | ||
|
|
||
| .mageforge-tab-order-line { | ||
| stroke: var(--mageforge-color-blue); | ||
| stroke-width: 1.5; | ||
| stroke-opacity: 0.5; | ||
| stroke-dasharray: 4 3; | ||
| fill: none; | ||
| } | ||
|
|
||
| .mageforge-tab-order-line--negative { | ||
| stroke: var(--mageforge-color-red); | ||
| } | ||
|
|
||
| .mageforge-tab-order-badge { | ||
| position: absolute; | ||
| width: 20px; | ||
| height: 20px; | ||
| border-radius: 50%; | ||
| background: var(--mageforge-color-blue); | ||
| color: var(--mageforge-color-white); | ||
| font-family: var(--mageforge-font-family); | ||
| font-size: 10px; | ||
| font-weight: 700; | ||
| line-height: 1; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| transform: translate(-50%, -50%); | ||
| box-shadow: 0 1px 4px rgba(0, 0, 0, 0.4); | ||
| } | ||
|
|
||
| .mageforge-tab-order-badge--negative { | ||
| background: var(--mageforge-color-red); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getShowButtonLabels()reads raw config viagetValue()and compares strictly to the string'0'. SincegetValue()returnsmixed, non-string values (e.g. int 0/1) would make this behave incorrectly. Consider usingisSetFlag()for this Yes/No config path (and rely onconfig.xmlfor the default).