SepTop: slightly refactor _execute calls#1930
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
_execute calls_execute calls
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
- Coverage 94.60% 91.34% -3.27%
==========================================
Files 206 206
Lines 18296 18285 -11
==========================================
- Hits 17309 16702 -607
- Misses 987 1583 +596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , lgtm! The missing lines in codecov are probably covered by a slow test?
Just looked and that's indeed the case. It's the five lines in the execute call 😅. They will only get called when you do the integration tests. |
|
No API break detected ✅ |
Fixes #1919
Main tasks:
_executeback into the base units._executerather thanrunChecklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin