Open
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
Author
|
pre-commit.ci autofix |
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Member
Author
|
pre-commit.ci autofix |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
- Coverage 94.78% 90.45% -4.34%
==========================================
Files 210 214 +4
Lines 18841 18968 +127
==========================================
- Hits 17859 17158 -701
- Misses 982 1810 +828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbaumann
requested changes
Apr 20, 2026
Contributor
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , this looks great, just left some small comments.
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
…fe into septop_analysis_unit
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
|
No API break detected ✅ |
hannahbaumann
approved these changes
Apr 23, 2026
Contributor
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , lgtm! Is the failing codecov something we should be concerned about or is this related to slow tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1917
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin