Skip to content

update go sample to declarative function and add multiple functions sample#78

Merged
benjaminhuo merged 5 commits intoOpenFunction:mainfrom
lizzzcai:add-declarative-function-api-examples-0527
May 27, 2022
Merged

update go sample to declarative function and add multiple functions sample#78
benjaminhuo merged 5 commits intoOpenFunction:mainfrom
lizzzcai:add-declarative-function-api-examples-0527

Conversation

@lizzzcai
Copy link
Copy Markdown
Member

@lizzzcai lizzzcai commented May 27, 2022

follow up PR of OpenFunction/functions-framework-go#48

Need to release the builder openfunction/builder-go:latest (OpenFunction/builder#56) before merging this.

@lizzzcai
update hello-world-go to declarative function, add a multiple functio…
2b1b52b 
…ns sample

Signed-off-by: Lize Cai <lize.cai@sap.com>
@benjaminhuo benjaminhuo requested review from tpiperatgod and webup May 27, 2022 07:56
lizzzcai added 3 commits May 27, 2022 16:05
@lizzzcai
update go ff to v0.2.4
fbdfead 
Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai
update go-builder to v2.3.0, update go-ff to v0.3.0 in http sample
87f9b47 
Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai
update ff-go to v0.3.0 in knative go function samples
09bbeda 
Signed-off-by: Lize Cai <lize.cai@sap.com>
benjaminhuo
benjaminhuo reviewed May 27, 2022
View reviewed changes
Comment thread functions/knative/hello-world-go/go.mod Outdated
benjaminhuo
benjaminhuo reviewed May 27, 2022
View reviewed changes
Comment thread functions/knative/hello-world-go/README.md Outdated
@lizzzcai
add suffix for builder-go -> builder-go:v2.3.0-1.16
4af33e5 
Signed-off-by: Lize Cai <lize.cai@sap.com>
@benjaminhuo
Copy link
Copy Markdown
Member

benjaminhuo commented May 27, 2022

I'll merge this once the builder is pushed to openfunction dockerhub
@lizzzcai let me know your private dockerhub once the builder is pushed to it, I'll sync it to openfunction's

@lizzzcai
Copy link
Copy Markdown
Member Author

lizzzcai commented May 27, 2022 •
edited
Loading

I'll merge this once the builder is pushed to openfunction dockerhub @lizzzcai let me know your private dockerhub once the builder is pushed to it, I'll sync it to openfunction's

lizzzcai/buildpacks-run-go:v2.3.0-1.16 -> openfunctiondev/buildpacks-run-go:v2.3.0-1.16
lizzzcai/buildpacks-go116-build:v2.3.0-1.16 -> openfunctiondev/buildpacks-go116-build:v2.3.0-1.16
lizzzcai/builder-go:v2.3.0-1.16 -> openfunction/builder-go:v2.3.0-1.16, openfunction/builder-go:v2.3.0

@benjaminhuo
Copy link
Copy Markdown
Member

benjaminhuo commented May 27, 2022

image
builder uploaded including the new latest image, thanks @lizzzcai

@benjaminhuo benjaminhuo merged commit 3c6e8f7 into OpenFunction:main May 27, 2022
@lizzzcai lizzzcai deleted the add-declarative-function-api-examples-0527 branch May 27, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminhuo benjaminhuo benjaminhuo left review comments

@tpiperatgod tpiperatgod Awaiting requested review from tpiperatgod

@webup webup Awaiting requested review from webup

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lizzzcai @benjaminhuo