Pimpleback IZ Pod Fix#259
Merged
yungcomputerchair merged 2 commits intoOpenFusionProject:masterfrom Oct 8, 2023
Merged
Conversation
yungcomputerchair
approved these changes
Sep 17, 2023
Member
yungcomputerchair
left a comment
yungcomputerchair
left a comment
There was a problem hiding this comment.
LGTM, will merge after refactor.
dongresource
approved these changes
Sep 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packet
sP_FE2CL_INSTANCE_MAP_INFOis now sent after the player load complete is acknowledged.This way, the player is loaded into the correct map square before sending the map info, which ensures the pods are properly loaded and can be properly disabled. While Infected Zones are usually in the same map square as the entry warp spot, this fixes the issue where Crystalline Caverns Infected Zone did not disable pods after a player(s) warped inside. This broke races in this IZ as well, because the pods were not given correct identifiers without proper initialization.
Solution by @JadeShrineMaiden and @CakeLancelot.