Skip to content

Proxied asset downloading #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yungcomputerchair merged 3 commits into from
Apr 22, 2026
Merged

Proxied asset downloading #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
910187d
Proxied asset downloading
yungcomputerchair Apr 21, 2026
3a7ad02
Cleanup imports
yungcomputerchair Apr 22, 2026
72b68aa
Bonus: Fix LaunchBehavior::Quit crashing game on Unix
yungcomputerchair Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export default function Home() {
}
stopLoading("launch");
setCurrentSession(undefined);
if (config!.launcher.launch_behavior == "hide") {
if (config!.launcher.launch_behavior != "stay_open") {
await getCurrentWindow().hide();
}
const exitCode: number = await invoke("do_launch");
Expand Down
17 changes: 17 additions & 0 deletions app/settings/LauncherSettingsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,23 @@ export default function LauncherSettingsTab({
}))
}
/>
<SettingControlDropdown
id="proxy_asset_downloads"
name="Proxy asset downloads over HTTPS"
options={[
{ key: "yes", value: true, label: "Yes" },
{ key: "no", value: false, label: "No" },
]}
defaultKey="yes"
oldValue={currentSettings.proxy_asset_downloads}
value={settings.proxy_asset_downloads}
onChange={(value) =>
setSettings((current) => ({
...current!,
proxy_asset_downloads: value,
}))
}
/>
<SettingControlDropdown
id="use_offline_caches"
name="Use offline caches when downloaded"
Expand Down
1 change: 1 addition & 0 deletions app/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export type LauncherSettings = {
launch_behavior: string;
game_cache_path: string;
offline_cache_path: string;
proxy_asset_downloads: boolean;
theme?: string;
};

Expand Down
3 changes: 2 additions & 1 deletion resources/defaults/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"check_for_updates": true,
"use_offline_caches": true,
"verify_offline_caches": false,
"launch_behavior": "hide"
"launch_behavior": "hide",
"proxy_asset_downloads": true
},
"game": {
"graphics_api": "dx9",
Expand Down
Loading
Loading