moved SetPDGLifeTime() to GateVSource::Initialize()#63
Merged
dsarrut merged 1 commit intoOpenGATE:developfrom Apr 18, 2016
JStrydhorst:rdm-fixed-num-primaries
Merged
moved SetPDGLifeTime() to GateVSource::Initialize()#63dsarrut merged 1 commit intoOpenGATE:developfrom JStrydhorst:rdm-fixed-num-primaries
dsarrut merged 1 commit intoOpenGATE:developfrom
JStrydhorst:rdm-fixed-num-primaries
Conversation
ThomasDeschler
added a commit
to ThomasDeschler/Gate
that referenced
this pull request
Oct 5, 2016
Revert "Merge pull request OpenGATE#63 from JStrydhorst/rdm-fixed-num-primaries" This reverts commit 18cebd1, reversing changes made to 3d7e6aa.
ThomasDeschler
added a commit
to ThomasDeschler/Gate
that referenced
this pull request
Oct 5, 2016
Revert "Merge pull request OpenGATE#63 from JStrydhorst/rdm-fixed-num-primaries" This reverts commit 18cebd1, reversing changes made to 3d7e6aa.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor fix to the fixed number of primaries mode when using RadioactiveDecay. The call to SetPDGLifeTime(0) to let Gate control the decay time of radioactive ions was in the GateVSource::GetNextTime() function. Setting the lifetime to zero before every event isn't necessary, and in fixed number of primaries mode, GetNextTime isn't used at all, so the decay timing was controlled by Geant4. Moving the call to GateVSource::Initialize() makes the behaviour consistent between timed runs and those with fixed numbers of primaries.