Multiple CCPs in MarginClientExample#174
Merged
jodastephen merged 7 commits intomainfrom May 17, 2022
Merged
Conversation
akshaishah
approved these changes
Nov 23, 2021
Contributor
|
@cjkent do you still want this? |
Contributor
Author
|
I think it's still worth having. The issue is that the build was already broken when I started making my changes. Maybe the build has been fixed in the intervening 8 months and I can merge |
Contributor
Author
|
The integration tests were broken and they still are and I have absolutely no idea why. Which is why I never followed up on this PR. |
Contributor
|
@cjkent Can you recheck this now the build passes, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds files for LCH and ICE SPAN plus the ability to run one or more CCPs at the same time.
The default behaviour is unchanged (running LCH calcs).