Merged
Conversation
brianweller89
approved these changes
Oct 3, 2017
| .map(str -> LoaderUtils.parseDouble(str)) | ||
| .ifPresent(notional -> stepBuilder.add(ValueStep.of(date, ValueAdjustment.ofReplace(notional)))); | ||
| } | ||
| ImmutableList<ValueStep> vnotionals = stepBuilder.build(); |
Contributor
There was a problem hiding this comment.
vNotionals rather than vnotionals
| .map(str -> LoaderUtils.parseDoublePercent(str)) | ||
| .ifPresent(fixedRate -> stepBuilder.add(ValueStep.of(date, ValueAdjustment.ofReplace(fixedRate)))); | ||
| } | ||
| ImmutableList<ValueStep> vnotionals = stepBuilder.build(); |
Contributor
There was a problem hiding this comment.
rates rather than notionals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are lots of variable elements in Strata swaps, but the most crucial are notionals and fixed rates. While in theory these could be different on each leg, in most cases they are not. Thus, this PR concentrates on the standard variable cases - notional and fixed rate affecting all legs equally.