Add Attributes.containsAttribute() shorthand method#2004
Merged
jodastephen merged 3 commits intomasterfrom Jun 19, 2019
Merged
Conversation
jodastephen
reviewed
Jun 19, 2019
| * @param type the type to find | ||
| * @return true if a matching attribute is present | ||
| */ | ||
| public default <T> boolean hasAttribute(AttributeType<T> type) { |
Contributor
There was a problem hiding this comment.
Looking around, we tend to use containsXxx() for methods like this.
jodastephen
approved these changes
Jun 19, 2019
jodastephen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple helper method to Attributes -
thing.hasAttribute(foo)reads more clearly thanthing.findAttribute(foo).isPresent()and is also nicer to use in functional code.