Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestNG from TestHelper #2007

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

commented Jun 20, 2019

Allows the class to be used from tests in either JUnit or TestNG.
Without this TestNG and JUnit are both seen by maven when running tests.

Remove TestNG from TestHelper
Allows the class to be used from JUnit tests
Without this TestNG and JUnit are both seen by maven when running tests

@jodastephen jodastephen requested a review from cjkent Jun 20, 2019

@@ -521,14 +518,14 @@ public void flush() {
*/
public static void assertUtilityClass(Class<?> clazz) {
assertNotNull(clazz, "assertUtilityClass() called with null class");
assertTrue(Modifier.isFinal(clazz.getModifiers()), "Utility class must be final");
assertEquals(Modifier.isFinal(clazz.getModifiers()), true, "Utility class must be final");

This comment has been minimized.

Copy link
@cjkent

cjkent Jun 20, 2019

Member

Is it worth defining assertTrue? It's such a standard method. assertEquals(..., true) seems a bit odd.

This comment has been minimized.

Copy link
@jodastephen

jodastephen Jun 20, 2019

Author Member

These are private methods, and since they are only used in a couple of places, it didn't seem worthwhile.

@cjkent

cjkent approved these changes Jun 20, 2019

@jodastephen jodastephen merged commit 615dc22 into master Jun 20, 2019

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - examples/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma) No new issues
Details
security/snyk - pom.xml (OpenGamma) No new issues
Details
workflow Workflow: workflow
Details

@delete-merged-branch delete-merged-branch bot deleted the topic/test-helper branch Jun 20, 2019

@jodastephen jodastephen added this to the v2.5 milestone Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.