Merged
Conversation
Allows the class to be used from JUnit tests Without this TestNG and JUnit are both seen by maven when running tests
cjkent
reviewed
Jun 20, 2019
| public static void assertUtilityClass(Class<?> clazz) { | ||
| assertNotNull(clazz, "assertUtilityClass() called with null class"); | ||
| assertTrue(Modifier.isFinal(clazz.getModifiers()), "Utility class must be final"); | ||
| assertEquals(Modifier.isFinal(clazz.getModifiers()), true, "Utility class must be final"); |
Contributor
There was a problem hiding this comment.
Is it worth defining assertTrue? It's such a standard method. assertEquals(..., true) seems a bit odd.
Contributor
Author
There was a problem hiding this comment.
These are private methods, and since they are only used in a couple of places, it didn't seem worthwhile.
cjkent
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the class to be used from tests in either JUnit or TestNG.
Without this TestNG and JUnit are both seen by maven when running tests.