Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestNG from TestHelper #2007

Merged
merged 1 commit into from Jun 20, 2019
Merged

Remove TestNG from TestHelper #2007

merged 1 commit into from Jun 20, 2019

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Jun 20, 2019

Allows the class to be used from tests in either JUnit or TestNG.
Without this TestNG and JUnit are both seen by maven when running tests.

Allows the class to be used from JUnit tests
Without this TestNG and JUnit are both seen by maven when running tests
@@ -521,14 +518,14 @@ public void flush() {
*/
public static void assertUtilityClass(Class<?> clazz) {
assertNotNull(clazz, "assertUtilityClass() called with null class");
assertTrue(Modifier.isFinal(clazz.getModifiers()), "Utility class must be final");
assertEquals(Modifier.isFinal(clazz.getModifiers()), true, "Utility class must be final");
Copy link
Member

@cjkent cjkent Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth defining assertTrue? It's such a standard method. assertEquals(..., true) seems a bit odd.

Copy link
Member Author

@jodastephen jodastephen Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are private methods, and since they are only used in a couple of places, it didn't seem worthwhile.

cjkent
cjkent approved these changes Jun 20, 2019
@jodastephen jodastephen merged commit 615dc22 into master Jun 20, 2019
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the topic/test-helper branch Jun 20, 2019
@jodastephen jodastephen added this to the v2.5 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants