Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove N^2 uniqueness checks in interpolators #2031
Conversation
wjnicholson
requested a review
from jodastephen
Jul 19, 2019
wjnicholson
assigned
jodastephen
Jul 19, 2019
jodastephen
requested changes
Jul 22, 2019
| */ | ||
| public static double[] noDuplicates(double[] argument, String name) { | ||
| notNull(argument, name); | ||
| if (argument.length > 0 && DoubleStream.of(argument).distinct().count() != argument.length) { |
This comment has been minimized.
This comment has been minimized.
jodastephen
Jul 22, 2019
Member
I wouldn't have thought DoubleStream.of(argument).distinct().count() was that fast?
.../collect/src/main/java/com/opengamma/strata/collect/DoubleArrayMath.java
Outdated
Show resolved
Hide resolved
| @@ -476,6 +562,10 @@ private static void swap(double[] keys, double[] values, int first, int second) | |||
|
|
|||
| /** | |||
| * Return the array lengths if they are the same, otherwise throws an {@code IllegalArgumentException}. | |||
| * | |||
This comment has been minimized.
This comment has been minimized.
| double[] yValuesSrt = new double[nDataPts]; | ||
|
|
||
| xValuesSrt = Arrays.copyOf(xValues, nDataPts); | ||
| double[] xValuesSrt = Arrays.copyOf(xValues, nDataPts); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
wjnicholson
Jul 23, 2019
•
Author
Member
Apparently .clone() may add a cast (since it's implicitly overriden from the Object::clone() method)
Arrays.copyOf() delegates to System.arrayCopy which is native, and doesn't involve a cast.
I'd have to benchmark to be sure.
Although https://stackoverflow.com/questions/12157300/clone-or-arrays-copyof says they are equivalent post JIT
...math/src/main/java/com/opengamma/strata/math/impl/interpolation/CubicSplineInterpolator.java
Outdated
| for (int j = i + 1; j < nDataPts; ++j) { | ||
| ArgChecker.isFalse(xValues[i] == xValues[j], "Data should be distinct"); | ||
| } | ||
| if (DoubleStream.of(xValues).distinct().count() != xValues.length) { |
This comment has been minimized.
This comment has been minimized.
jodastephen
approved these changes
Jul 29, 2019
wjnicholson
and others
added some commits
Jul 18, 2019
jodastephen
force-pushed the
topic/faster-duplication-checks
branch
from
8391972
to
c618d63
Jul 29, 2019
jodastephen
merged commit c79144e
into
master
Jul 29, 2019
13 checks passed
build
Workflow: build
Details
security/snyk - examples/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma)
No new issues
Details
security/snyk - pom.xml (OpenGamma)
No new issues
Details
delete-merged-branch
bot
deleted the
topic/faster-duplication-checks
branch
Jul 29, 2019
jodastephen
added this to the v2.6 milestone
Jul 29, 2019
jodastephen
added
the
Type:Enhancement
label
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
wjnicholson commentedJul 19, 2019
Not sure this is the best implementation - still seems a little boilerplatey.
Could definitely be streamlined with more ArgChecker methods, potentially ones that assert that a double array is sorted, unique, and doesn't contain NaN or infinity, but maybe that's overstepping what ArgChecker is responsible for.