Extend the CSV trade loader#2095
Merged
Merged
Conversation
Allow the standard parsing to be overridden for a given product type
akshaishah
approved these changes
Oct 14, 2019
| * This is called before the standard matching on the 'Product Type' column. | ||
| * As such, it allows the standard parsing to be replaced for a given type. | ||
| * | ||
| * @param typeUpper the upper case product type column |
Contributor
There was a problem hiding this comment.
Has 2 spaces after the parameter name always been a thing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the standard parsing to be overridden for a given product type