Skip to content

Extend the CSV trade loader#2095

Merged
jodastephen merged 1 commit into
masterfrom
topic/trade-parser-flexibility
Oct 14, 2019
Merged

Extend the CSV trade loader#2095
jodastephen merged 1 commit into
masterfrom
topic/trade-parser-flexibility

Conversation

@jodastephen
Copy link
Copy Markdown
Contributor

Allow the standard parsing to be overridden for a given product type

Allow the standard parsing to be overridden for a given product type
* This is called before the standard matching on the 'Product Type' column.
* As such, it allows the standard parsing to be replaced for a given type.
*
* @param typeUpper the upper case product type column
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has 2 spaces after the parameter name always been a thing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Strata, yes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it 👍

@jodastephen jodastephen merged commit 455a9bd into master Oct 14, 2019
@delete-merged-branch delete-merged-branch Bot deleted the topic/trade-parser-flexibility branch October 14, 2019 09:26
@jodastephen jodastephen added this to the v2.7 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants