Additional utilities for handling ZIP files#2120
Merged
Merged
Conversation
jodastephen
force-pushed
the
topic/zip-utils
branch
from
d8a5ced to
ad4e0c0
Compare
martynassateika
requested changes
Dec 4, 2019
| * @return the unzipped file, empty if not found | ||
| * @throws UncheckedIOException if an IO error occurs | ||
| */ | ||
| public static Optional<ArrayByteSource> unzipPathNameInMemory(BeanByteSource source, String relativePathName) { |
Contributor
There was a problem hiding this comment.
A null relative path doesn't make sense, but is currently accepted by this method, and would make it return Optional.empty.
| } catch (IOException ex) { | ||
| throw new UncheckedIOException(ex); | ||
| } | ||
| return entryNames; |
| if (deduplicate.add(new ZipKey(entry))) { | ||
| ArrayByteSource entrySource = ArrayByteSource.copyOf(ByteStreams.toByteArray(in)).withFileName(entry.getName()); | ||
| consumer.accept(entry.getName(), entrySource); | ||
|
|
| ArrayByteSource source2 = ArrayByteSource.ofUtf8("Hello Planet").withFileName("TestFile2.txt"); | ||
| ArrayByteSource zipFile = ZipUtils.zipInMemory(ImmutableList.of(source1, source2)).withFileName("Test.foo"); | ||
|
|
||
| ZipUtils.unzipInMemory(zipFile, (name, extracted) -> { |
Contributor
There was a problem hiding this comment.
If the BiConsumer wasn't invoked at all this test would still pass.
martynassateika
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend class to cover more zip/unzip use cases.