Add optional getters to IniFile and PropertySet#2132
Merged
Conversation
martynassateika
requested changes
Feb 7, 2020
|
|
||
| assertThat(test.isEmpty()).isEqualTo(true); | ||
| assertThat(test.contains("unknown")).isEqualTo(false); | ||
| assertThat(test.findValue("unknown")).isEmpty(); |
Contributor
There was a problem hiding this comment.
Could add this in test_of_multimap:
assertThatIllegalArgumentException().isThrownBy(() -> test.findValue("a"));
jodastephen
force-pushed
the
topic/ini
branch
from
5809261 to
3bd1b19
Compare
Integrate lists of properties with single properties without exceptions
martynassateika
approved these changes
Feb 7, 2020
Contributor
Isn't this exactly what |
Contributor
Author
|
Having methods like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional configuration turns out to be quite common