Add Guavate.tryCatchToOptional#2161
Merged
Merged
Conversation
Convert an exception throwing `getFoo()` method to an Optional returning `findFoo()` method
wjnicholson
reviewed
May 20, 2020
Comment on lines
+148
to
+149
| * @param <T> the type of the result | ||
| * @param supplier the supplier that might throw an exception |
Contributor
There was a problem hiding this comment.
Spacing looks odd here - is that double spaced?
| * | ||
| * @param <T> the type of the result | ||
| * @param supplier the supplier that might throw an exception | ||
| * @return the value wrapped in an exception, empty if the method returns null or an exception is thrown |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return the value wrapped in an exception, empty if the method returns null or an exception is thrown | |
| * @return the value wrapped in an optional, empty if the method returns null or an exception is thrown |
wjnicholson
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert an exception throwing
getFoo()method to anOptionalreturningfindFoo()method