Cache isEmpty separately from size in DenseLocalDateDoubleTimeSeries#2166
Merged
Conversation
jodastephen
reviewed
May 29, 2020
| if (e == 0) { | ||
| // take cached size if already calculated | ||
| int s = size; | ||
| boolean any = s != 0 ? s > 1 : validIndices().findAny().isPresent(); |
Contributor
There was a problem hiding this comment.
I suspect if you are worried about performance, looping over the double[] and calling isValidPoint would be quicker than the more weighty stream system. Also, I'd expect that size() and the constructors should set isEmpty.
jodastephen
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realised my previous PR would add a lot of computation in the case that we rarely access a time series