Accept any Collection of FailureItems when creating a ValueWithFailures

modules/collect/src/main/java/com/opengamma/strata/collect/result/ValueWithFailures.java

@@ -93,9 +93,22 @@ public static <T> ValueWithFailures<T> of(T successValue, FailureItem... failure
    * @return an instance wrapping the value and failures
    */
   public static <T> ValueWithFailures<T> of(T successValue, List<FailureItem> failures) {
+    // this method is retained to ensure binary compatibility
     return new ValueWithFailures<>(successValue, failures);
   }
 
+  /**
+   * Creates an instance wrapping the success value and failures.
+   *
+   * @param <T>  the type of the success value
+   * @param successValue  the success value
+   * @param failures  the failures
+   * @return an instance wrapping the value and failures
+   */
+  public static <T> ValueWithFailures<T> of(T successValue, Collection<FailureItem> failures) {
+    return new ValueWithFailures<>(successValue, ImmutableList.copyOf(failures));
+  }
+
   /**
    * Creates an instance using a supplier.
    * <p>

modules/collect/src/test/java/com/opengamma/strata/collect/result/ValueWithFailuresTest.java

@@ -56,6 +56,14 @@ public void test_of_list() {
     assertThat(test.getFailures()).isEqualTo(ImmutableList.of(FAILURE1, FAILURE2));
   }
 
+  @Test
+  public void test_of_set() {
+    ValueWithFailures<String> test = ValueWithFailures.of("success", ImmutableSet.of(FAILURE1, FAILURE2));
+    assertThat(test.hasFailures()).isEqualTo(true);
+    assertThat(test.getValue()).isEqualTo("success");
+    assertThat(test.getFailures()).containsExactlyInAnyOrder(FAILURE1, FAILURE2);
+  }
+
   @Test
   public void test_of_supplier_success() {
     ValueWithFailures<String> test = ValueWithFailures.of("", () -> "A");