Lookup FX swap convention by currency pair#2177
Merged
Merged
Conversation
Adds a useful way to lookup conventions Also complete the FX swap conventions for the key four currencies
akshaishah
reviewed
Jun 11, 2020
| * <p> | ||
| * The convention accessed will be for the conventional order of the currency pair. | ||
| * | ||
| * @param currencyPair the currency pair to get the convention for |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param currencyPair the currency pair to get the convention for | |
| * @param currencyPair the currency pair to get the convention for |
Contributor
Author
There was a problem hiding this comment.
In Strata, its two spaces :-)
akshaishah
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a useful way to lookup conventions
Also complete the FX swap conventions for the key four currencies