Parse bracketed numbers as negative numbers#2226
Merged
Conversation
jodastephen
suggested changes
Sep 17, 2020
modules/loader/src/main/java/com/opengamma/strata/loader/LoaderUtils.java
Outdated
Show resolved
Hide resolved
modules/loader/src/main/java/com/opengamma/strata/loader/LoaderUtils.java
Show resolved
Hide resolved
jodastephen
suggested changes
Sep 17, 2020
| assertThat(LoaderUtils.parseInteger("(23)")).isEqualTo(-23); | ||
| assertThatIllegalArgumentException() | ||
| .isThrownBy(() -> LoaderUtils.parseInteger("()")) | ||
| .withMessage("Unable to parse integer from '()'"); |
Contributor
There was a problem hiding this comment.
With AssertJ you have to put the withMessage before the method that actually throws, otherwise the message is not picked up. Needs fixing in all the methods below.
Contributor
There was a problem hiding this comment.
My mistake. This is correctly testing the message that is thrown.
jodastephen
approved these changes
Sep 17, 2020
| assertThat(LoaderUtils.parseInteger("(23)")).isEqualTo(-23); | ||
| assertThatIllegalArgumentException() | ||
| .isThrownBy(() -> LoaderUtils.parseInteger("()")) | ||
| .withMessage("Unable to parse integer from '()'"); |
Contributor
There was a problem hiding this comment.
My mistake. This is correctly testing the message that is thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.