Fix Hungarian working Saturdays for 2020.#2236
Merged
brianweller89 merged 2 commits intomasterfrom Oct 2, 2020
Merged
Conversation
Per below sources, the August working Saturday for 2020 is 1 week after the long weekend. https://helpers.hu/other/bank-holidays-in-hungary-in-2020/ https://www.timeanddate.com/holidays/hungary/2020 The last time that National Day fell on a Thursday was 2015. On this occasion the working Saturday was two weeks prior to the long weekend. Assumedly that's where we derived our logic from So unclear what the logic is for deciding where the working Saturday falls, it may not even be algorithmic. This change ensures we get the right date for 2020.
jodastephen
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per below sources, the August working Saturday for 2020 is 1 week after the long weekend.
https://helpers.hu/other/bank-holidays-in-hungary-in-2020/
https://www.timeanddate.com/holidays/hungary/2020
The last time that National Day fell on a Thursday was 2015. On this occasion the working Saturday was two weeks prior to the long weekend. Assumedly that's where we derived our logic from.
https://www.timeanddate.com/holidays/hungary/2015
So unclear what the logic is for deciding where the working Saturday falls, it may not even be algorithmic.
This change ensures we at least get the right date for 2020. Probably need to revisit in 2026!