Add a plugin for Position CSV parsing#2285
Merged
mergify[bot] merged 2 commits intomainfrom Feb 1, 2021
Merged
Conversation
Allow application code to plugin their own products Approach is more standard than the resolver used up to now
skitini
requested changes
Feb 1, 2021
Contributor
skitini
left a comment
skitini
left a comment
There was a problem hiding this comment.
Just the JavaDoc changes for the four plugin classes
| import com.opengamma.strata.product.etd.EtdFuturePosition; | ||
|
|
||
| /** | ||
| * Handles the CSV file format for CDS index trades. |
Contributor
There was a problem hiding this comment.
Very minor but the JavaDoc for the different position csv plugin classes all refer to CDS index trades
skitini
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow application code to plugin their own products
Approach is more standard than the resolver used up to now