Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin for Position CSV parsing #2285

Merged
merged 2 commits into from Feb 1, 2021
Merged

Conversation

jodastephen
Copy link
Member

Allow application code to plugin their own products
Approach is more standard than the resolver used up to now

Allow application code to plugin their own products
Approach is more standard than the resolver used up to now
Copy link
Contributor

@skitini skitini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the JavaDoc changes for the four plugin classes

import com.opengamma.strata.product.etd.EtdFuturePosition;

/**
* Handles the CSV file format for CDS index trades.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor but the JavaDoc for the different position csv plugin classes all refer to CDS index trades

@jodastephen jodastephen added the auto-merge Merge when build finishes label Feb 1, 2021
@mergify mergify bot merged commit 07cd084 into main Feb 1, 2021
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the topic/position-parse-plugin branch February 1, 2021 14:23
@jodastephen jodastephen added this to the v2.9 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Merge when build finishes Type:Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants