Fix time-series merge to correctly handle weekends#2355
Merged
jodastephen merged 2 commits intomainfrom Sep 6, 2021
Merged
Conversation
The merge method did not set the `containsWeekends` flag This caused an exception on building
wjnicholson
approved these changes
Sep 6, 2021
| * @return this builder | ||
| */ | ||
| public LocalDateDoubleTimeSeriesBuilder merge(LocalDateDoublePoint point, DoubleBinaryOperator operator) { | ||
| ArgChecker.notNull(point, "point"); |
Contributor
There was a problem hiding this comment.
Did you not want to leave the notNull check here?
The equivalent put(LocalDateDoublePoint point) has a similar check before delegating
wjnicholson
approved these changes
Sep 6, 2021
|
Thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge method did not set the
containsWeekendsflagThis caused an exception on building