-
Notifications
You must be signed in to change notification settings - Fork 1
User-created basemaps #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying geoinsight with
|
| Latest commit: |
f77b94a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f4098e7.geoinsight.pages.dev |
| Branch Preview URL: | https://base-maps.geoinsight.pages.dev |
BryonLewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time yet to run branch in geoinsight. I've only looked through the PR.
The only comment I feel is strongly reccomended is the one for guarding against adding bad styles into the list (testing and verification through the preview). Other than that one all others can be marked as suggestions and feel free to push back on any of them.
Tomorrow I'll go a bit more into detail and test the branch but I don't think I would have much else.
|
I've run through it this morning and it works great. The only other very minor suggestion is maybe moving the '+ New' from the bottom of the list to the heading or top where it has 'Base Map Options'. Just so you don't have to scroll to get to the adding new button. |
…r to match colormap creation button
Moved to the top of the basemaps list in f77b94a. I also updated the text and color to match the "+ Create Custom Colormap" button we have in the colormaps list |
BryonLewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR does the following:
Basemapand a set of default objects that are created during migrationThe following video demonstrates the new functionality:
https://drive.google.com/file/d/16pZCFmvi6-MuEhlnG6yqLWOy3wcJBSKl/view?usp=sharing
Resolves #240.