Skip to content

Conversation

@annehaley
Copy link
Collaborator

This PR does the following:

  • Create new model Basemap and a set of default objects that are created during migration
  • Make client map creation/handling more abstract to allow switching basemap styles
  • Add a menu to the controls bar for users to select a basemap
  • Add a "New" button to the bottom of the basemaps menu which opens a dialog for creating a new basemaps
  • In the basemap creation dialog, allow the user to specify the basemap with a tile URL or a style JSON

The following video demonstrates the new functionality:
https://drive.google.com/file/d/16pZCFmvi6-MuEhlnG6yqLWOy3wcJBSKl/view?usp=sharing

Resolves #240.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 10, 2025

Deploying geoinsight with  Cloudflare Pages  Cloudflare Pages

Latest commit: f77b94a
Status: ✅  Deploy successful!
Preview URL: https://4f4098e7.geoinsight.pages.dev
Branch Preview URL: https://base-maps.geoinsight.pages.dev

View logs

@annehaley annehaley changed the title Base maps User-created basemaps Dec 10, 2025
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time yet to run branch in geoinsight. I've only looked through the PR.
The only comment I feel is strongly reccomended is the one for guarding against adding bad styles into the list (testing and verification through the preview). Other than that one all others can be marked as suggestions and feel free to push back on any of them.
Tomorrow I'll go a bit more into detail and test the branch but I don't think I would have much else.

@BryonLewis
Copy link
Collaborator

I've run through it this morning and it works great. The only other very minor suggestion is maybe moving the '+ New' from the bottom of the list to the heading or top where it has 'Base Map Options'. Just so you don't have to scroll to get to the adding new button.

@annehaley
Copy link
Collaborator Author

The only other very minor suggestion is maybe moving the '+ New' from the bottom of the list to the heading or top where it has 'Base Map Options'. Just so you don't have to scroll to get to the adding new button.

Moved to the top of the basemaps list in f77b94a. I also updated the text and color to match the "+ Create Custom Colormap" button we have in the colormaps list

@annehaley annehaley requested a review from BryonLewis December 11, 2025 22:24
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annehaley annehaley merged commit 7971b5c into master Dec 12, 2025
6 checks passed
@annehaley annehaley deleted the base-maps branch December 12, 2025 14:37
@annehaley annehaley mentioned this pull request Dec 12, 2025
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow users to add new base maps

4 participants