Changed percentiles constant #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ok, I agree with your suggestion that this data would be better stored in a file, so I added this commit: 77d98f0. However, rather than storing as a pickled file, I elected to store this data as JSON since that is more human-readable. The trained downscaling model data doesn't need to be human readable because model weights aren't intended to be interpretable, but this content is more intuitive and I'd like to maintain that interpretability. |
annehaley
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've pasted the dictionary in the constants and I'm guessing it will work, although I still can't run from command line due to the large-image issue.
It's ugly to have the whole dictionary in constants, so I think it would be better saved with pickle, analogous to how we reference the trained downscaling model. (I'll leave that for you if it's easy enough to implement with the URLs and constants scheme you set up.)