Skip to content
This repository was archived by the owner on Nov 21, 2023. It is now read-only.

convert gradle to maven - WIP #2

Merged
merged 1 commit into from
Aug 26, 2021
Merged

convert gradle to maven - WIP #2

merged 1 commit into from
Aug 26, 2021

Conversation

@JerryShea
Copy link

@JerryShea JerryShea commented Aug 25, 2021

No description provided.

@JerryShea JerryShea mentioned this pull request Aug 25, 2021
Closed
minborg
minborg approved these changes Aug 26, 2021
View reviewed changes
Copy link

@minborg minborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@JerryShea JerryShea merged commit 05ddab7 into OpenHFT:master Aug 26, 2021
@JerryShea JerryShea deleted the feature/gradle_to_maven branch August 26, 2021 08:20
@minborg
Copy link

minborg commented Aug 30, 2021

This works under IDEA but not under Maven:

[INFO] Running net.openhft.sg.ParametersFieldsNameCollisionTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.61 s <<< FAILURE! - in net.openhft.sg.ParametersFieldsNameCollisionTest
[ERROR] net.openhft.sg.ParametersFieldsNameCollisionTest.testParametersFieldsNameCollision  Time elapsed: 0.562 s  <<< ERROR!
java.lang.RuntimeException: org.eclipse.jdt.internal.compiler.problem.AbortCompilation: Pb(324) The type java.lang.Class cannot be resolved. It is indirectly referenced from required .class files
	at net.openhft.sg.ParametersFieldsNameCollisionTest.getFactoryForTest(ParametersFieldsNameCollisionTest.java:36)
	at net.openhft.sg.ParametersFieldsNameCollisionTest.testParametersFieldsNameCollision(ParametersFieldsNameCollisionTest.java:43)
Caused by: org.eclipse.jdt.internal.compiler.problem.AbortCompilation: Pb(324) The type java.lang.Class cannot be resolved. It is indirectly referenced from required .class files
	at net.openhft.sg.ParametersFieldsNameCollisionTest.getFactoryForTest(ParametersFieldsNameCollisionTest.java:34)
	at net.openhft.sg.ParametersFieldsNameCollisionTest.testParametersFieldsNameCollision(ParametersFieldsNameCollisionTest.java:43)

... MORE ERRORS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@minborg minborg minborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JerryShea @minborg