Add support to turn CV1's display on#57
Merged
noname22 merged 3 commits intoOpenHMD:dev-oculus-cv1from Jun 2, 2016
Merged
Conversation
| set_coordinate_frame(priv, priv->coordinate_frame); | ||
|
|
||
| // Turn the screens on | ||
| // TODO: this should probably be done conditionnally for the CV1 |
Member
There was a problem hiding this comment.
Can you fix this todo? Do we track which version we are using anywhere?
Contributor
Author
There was a problem hiding this comment.
It is tracked, but not really robustly: desc->revision contains the index of the device ID in our device ID list.
Member
There was a problem hiding this comment.
Oh okay, it would be good to have so we don't send the wrong message to devices. Maybe as a enum field on the rift_priv struct?
Member
|
Cool, nice work. One comment tho. Cheers, Jakob. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.