fix(frontend): pin axios version to mitigate supply chain attack#13670
Merged
fix(frontend): pin axios version to mitigate supply chain attack#13670
Conversation
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Simple, pragmatic security fix. Core change is solid.
| "@xterm/addon-fit": "^0.11.0", | ||
| "@xterm/xterm": "^6.0.0", | ||
| "axios": "^1.13.5", | ||
| "axios": "1.13.5", |
Collaborator
There was a problem hiding this comment.
🟢 Acceptable: Pinning to exact version is the right pragmatic choice here.
Security verification: I confirmed axios@1.14.1 no longer exists on npm (latest is 1.14.0), validating that the threat was real and the compromised version was pulled.
Minor improvement suggestions:
- Add an
Evidencesection to the PR description showingnpm install && npm run buildsucceeds - Consider checking the "Include in Release Notes" box - users should know about this security fix
- Document the upgrade path: Will you stay on 1.13.5 long-term or upgrade to 1.14.0+ once vetted?
None of these block the PR - the core fix is sound.
Contributor
enyst
approved these changes
Mar 31, 2026
Collaborator
enyst
left a comment
There was a problem hiding this comment.
Thank you, it helps.
I think it’s worth looking into the npm links shared by @llamantino , to require ~7 days since the package release. Otherwise some dependabot update could bring in a compromised package. cc: @aivong-openhands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR
axios@1.14.1 has been compromised with a malicious dependency (plain-crypto-js). Remove the caret from the version specifier to prevent accidental resolution to the compromised version.
1.13.5by removing the^prefix from the version specifier infrontend/package.jsonnpm installornpm updatefrom resolving to the compromisedaxios@1.14.1, which introduces amalicious dependency (
plain-crypto-js)Context
axios@1.14.1 has been identified as compromised in an active supply chain attack. The malicious
plain-crypto-jspackageis an obfuscated dropper that executes shell commands, stages payloads in temp directories, and destroys forensic
evidence.
We are currently safe — our
package-lock.jsonalready pins axios at1.13.5with a verified integrity hash, andnpm ci(used in CI) strictly respects the lockfile. However, the previous^1.13.5specifier meant that any developerrunning
npm installornpm updatecould inadvertently resolve to 1.14.1 and update the lockfile. Pinning the exactversion eliminates that risk
Demo Screenshots/Videos
Change Type
Checklist
Fixes
Resolves #(issue)
Release Notes
To run this PR locally, use the following command:
GUI with Docker: