Skip to content

check node.js req for 20.x or later#5877

Merged
enyst merged 2 commits into
OpenHands:mainfrom
ketan1741:node_version
Dec 29, 2024
Merged

check node.js req for 20.x or later#5877
enyst merged 2 commits into
OpenHands:mainfrom
ketan1741:node_version

Conversation

@ketan1741

Copy link
Copy Markdown
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Fixes node.js version >=20.x requirement in Makefile and Development.md

Link of any specific issues this addresses

@enyst enyst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I assume you tested the makefile?

@ketan1741

Copy link
Copy Markdown
Contributor Author

Thank you! I assume you tested the makefile?

on it, if [ "$${NODE_VERSION_ARRAY[0]}" -gt 20 ] do you want me use ge or gt?

@enyst

enyst commented Dec 28, 2024

Copy link
Copy Markdown
Member

Not my field, but I must have seen we're using 22 in fact... Cc: @amanape

@ketan1741

ketan1741 commented Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Not my field, but I must have seen we're using 22 in fact... Cc: @amanape

yeah I see that here too. But the checks passed for 20.18.1

@ketan1741

Copy link
Copy Markdown
Contributor Author

@enyst Hey, do we merge this?

@enyst enyst merged commit 194181a into OpenHands:main Dec 29, 2024
@enyst

enyst commented Dec 29, 2024

Copy link
Copy Markdown
Member

Sure, thanks!

@amanape

amanape commented Dec 30, 2024

Copy link
Copy Markdown
Contributor

Sorry for the late response. The app is confirmed to be supported up to the recommended stable release (v22) of Node. Higher versions break the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants