check node.js req for 20.x or later#5877
Merged
Merged
Conversation
enyst
approved these changes
Dec 28, 2024
enyst
left a comment
Member
There was a problem hiding this comment.
Thank you! I assume you tested the makefile?
Contributor
Author
on it, |
Member
|
Not my field, but I must have seen we're using 22 in fact... Cc: @amanape |
Contributor
Author
Contributor
Author
|
@enyst Hey, do we merge this? |
Member
|
Sure, thanks! |
Contributor
|
Sorry for the late response. The app is confirmed to be supported up to the recommended stable release (v22) of Node. Higher versions break the app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
node.jsversion>=20.xrequirement inMakefileandDevelopment.mdLink of any specific issues this addresses