Update run_id: remove "eval_" prefix #389
Conversation
|
@OpenHands please resolve conflicts |
|
I'm on it! simonrosenberg can track my progress at all-hands.dev |
Resolved merge conflicts in: - benchmarks/swebenchmultimodal/eval_infer.py: Keep run_id without 'eval_' prefix - benchmarks/swtbench/eval_infer.py: Keep run_id without 'eval_' prefix, use MODEL_NAME_OR_PATH Co-authored-by: openhands <openhands@all-hands.dev>
|
I've successfully resolved the merge conflicts in PR #389 and pushed the changes. Summary of ChangesMerged
These changes are consistent with the PR's purpose of removing the "eval_" prefix from |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like or Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
|
@OpenHands fix precommit hooks |
|
I'm on it! simonrosenberg can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
|
I've successfully fixed the PR #389 by: Checklist
Summary of ChangesThe PR diff now only shows:
The changes have been pushed to the |
PR OpenHands#389 intentionally removed the eval_ prefix from run_ids in swtbench and swebenchmultimodal. The NeMo PR had re-added it. Revert to the current convention (bare stem, no prefix).
PR #389 intentionally removed the eval_ prefix from run_ids in swtbench and swebenchmultimodal. The NeMo PR had re-added it. Revert to the current convention (bare stem, no prefix).
* update run_id * Revert vendor changes to match main Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
* update run_id * Revert vendor changes to match main Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
run_idhad been modified previously to be directly equal to the github action run id without theeval_prefix.Here there are fallbacks / bits of code that use the previous version of run_id.