(feat)Rich logging#413
Conversation
juanmichelini
left a comment
There was a problem hiding this comment.
tested both with and without RICH_LOGGING=1, LGTM
|
thanks @e-dobrowolska ! |
|
@OpenHands please fix the precommit hoooks so we can merge it. do minimal changes require to fix the precommit hooks only |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- Fix pyright type errors in console_logging.py: - Add None checks for sys.__stdout__.flush() calls - Change conversation parameter type from object to Any - Remove unused variable n_events - Fix import ordering per ruff formatting rules Co-authored-by: openhands <openhands@all-hands.dev>
Summary of WorkI successfully fixed all pre-commit hook failures in PR #413 "(feat)Rich logging" to make it ready for merge. Request Verification ✅
Changes MadeFile:
Files: Verification
The PR is now ready to merge! 🎉 |
| @@ -0,0 +1,101 @@ | |||
| # Rich Logging | |||
There was a problem hiding this comment.
Does this require its own md file? Or should it be a section of the README.md? @juanmichelini
There was a problem hiding this comment.
@OpenHands notice the comment by simon and create a PR that addresses only that.
There was a problem hiding this comment.
I'm on it! juanmichelini can track my progress at all-hands.dev
There was a problem hiding this comment.
Summary of Work
I successfully addressed Simon's feedback on PR #413 by creating a new PR #430 that consolidates the logging documentation.
What Was Done
Created PR #430: "docs: Move rich logging documentation to README.md"
- URL: docs: Move rich logging documentation to README.md #430
- Branch:
move-logging-docs-to-readme
Changes Made
✅ Moved rich logging documentation from benchmarks/utils/logging.md into the main README.md as a new section (placed after "Running Benchmarks")
✅ Deleted the separate file benchmarks/utils/logging.md to consolidate all user-facing documentation
Verification Checklist
- ✅ Request completely addressed: Simon asked whether logging docs should be separate or in README - they're now in README
- ✅ Changes are concise: Only 2 files modified (+103 lines in README, -101 lines from deleted file)
- ✅ No functionality changes: Pure documentation reorganization
- ✅ All instructions followed: Created a PR addressing ONLY Simon's comment, no other changes
- ✅ Changes pushed and PR created successfully
The PR is now ready for review by @simonrosenberg and @juanmichelini.
Move logging documentation from separate benchmarks/utils/logging.md file into the main README.md as a new section. This makes the documentation more discoverable and consolidates all user-facing docs in one place. Addresses review feedback from @simonrosenberg on PR #413. Co-authored-by: openhands <openhands@all-hands.dev>
* docs: Move rich logging documentation to README.md Move logging documentation from separate benchmarks/utils/logging.md file into the main README.md as a new section. This makes the documentation more discoverable and consolidates all user-facing docs in one place. Addresses review feedback from @simonrosenberg on PR #413. Co-authored-by: openhands <openhands@all-hands.dev> * docs: Condense Rich Logging section to essential info Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
* (feat)rich logging * (chore)remove unused dependency
* docs: Move rich logging documentation to README.md Move logging documentation from separate benchmarks/utils/logging.md file into the main README.md as a new section. This makes the documentation more discoverable and consolidates all user-facing docs in one place. Addresses review feedback from @simonrosenberg on PR OpenHands#413. Co-authored-by: openhands <openhands@all-hands.dev> * docs: Condense Rich Logging section to essential info Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
* (feat)rich logging * (chore)remove unused dependency
* docs: Move rich logging documentation to README.md Move logging documentation from separate benchmarks/utils/logging.md file into the main README.md as a new section. This makes the documentation more discoverable and consolidates all user-facing docs in one place. Addresses review feedback from @simonrosenberg on PR OpenHands#413. Co-authored-by: openhands <openhands@all-hands.dev> * docs: Condense Rich Logging section to essential info Co-authored-by: openhands <openhands@all-hands.dev> --------- Co-authored-by: openhands <openhands@all-hands.dev>
This PR brings an optional, richer console logging experience to all the benchmark inference scripts.
What changed
benchmarks/utils/console_logging.pybenchmarks/utils/conversation.py)benchmarks/utils/evaluation.pysummarize_instance(...)) in all the main benchmark runner scripts:benchmarks/swebench/run_infer.pybenchmarks/swebenchmultimodal/run_infer.pybenchmarks/swtbench/run_infer.pybenchmarks/multiswebench/run_infer.pybenchmarks/commit0/run_infer.pybenchmarks/gaia/run_infer.pybenchmarks/openagentsafety/run_infer.pybenchmarks/utils/logging.mdfor how it looks and actsBehavior impact
logs/instance_<id>.loglogs/instance_<id>.output.logHow to enable
export RICH_LOGGING=1