Add --critic #58
Merged
Merged
Conversation
add --critic PassCritic
Fix formatting in README for build images section
add more update on commands
Updated the critic option to be case-insensitive and added additional parameters for evaluation.
juanmichelini
approved these changes
Oct 28, 2025
Collaborator
|
Thanks @marscod! |
juanmichelini
added a commit
that referenced
this pull request
Oct 31, 2025
This reverts commit 23e19a9.
xingyaoww
added a commit
that referenced
this pull request
Nov 3, 2025
* Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Clean up resume logic and improve code clarity - Simplify comments and logging messages - Use more concise intersection operator (&) - Remove redundant logging in _prepare_instances_for_resume - Revert --split default to keep it required (minimal change) Co-authored-by: openhands <openhands@all-hands.dev> * Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Removed duplicated code * Fix resume logic finishes incomplete last attempt before continuing * Revert "Add --critic (#58)" This reverts commit 23e19a9. * Revert "Implement GAIA benchmark (#54)" This reverts commit 4afba8f. * bring gaia back * revert pyproject --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Xingyao Wang <xingyao@all-hands.dev>
juanmichelini
pushed a commit
that referenced
this pull request
Dec 17, 2025
* Fix formatting in README for build images section add --critic PassCritic * Update evaluation command in README add more update on commands * Fix formatting in README for evaluation command * Change critic option to 'pass' and update evaluation command Updated the critic option to be case-insensitive and added additional parameters for evaluation.
juanmichelini
added a commit
that referenced
this pull request
Dec 17, 2025
* Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Clean up resume logic and improve code clarity - Simplify comments and logging messages - Use more concise intersection operator (&) - Remove redundant logging in _prepare_instances_for_resume - Revert --split default to keep it required (minimal change) Co-authored-by: openhands <openhands@all-hands.dev> * Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Removed duplicated code * Fix resume logic finishes incomplete last attempt before continuing * Revert "Add --critic (#58)" This reverts commit da8976f. * Revert "Implement GAIA benchmark (#54)" This reverts commit ade2f62. * bring gaia back * revert pyproject --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Xingyao Wang <xingyao@all-hands.dev>
KTanmay1
pushed a commit
to Ethara-Ai/milo-bench
that referenced
this pull request
Mar 3, 2026
* Fix formatting in README for build images section add --critic PassCritic * Update evaluation command in README add more update on commands * Fix formatting in README for evaluation command * Change critic option to 'pass' and update evaluation command Updated the critic option to be case-insensitive and added additional parameters for evaluation.
KTanmay1
pushed a commit
to Ethara-Ai/milo-bench
that referenced
this pull request
Mar 3, 2026
* Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Clean up resume logic and improve code clarity - Simplify comments and logging messages - Use more concise intersection operator (&) - Remove redundant logging in _prepare_instances_for_resume - Revert --split default to keep it required (minimal change) Co-authored-by: openhands <openhands@all-hands.dev> * Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Removed duplicated code * Fix resume logic finishes incomplete last attempt before continuing * Revert "Add --critic (OpenHands#58)" This reverts commit 23e19a9. * Revert "Implement GAIA benchmark (OpenHands#54)" This reverts commit 4afba8f. * bring gaia back * revert pyproject --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Xingyao Wang <xingyao@all-hands.dev>
KTanmay1
pushed a commit
to Ethara-Ai/milo-bench
that referenced
this pull request
Mar 3, 2026
* Fix formatting in README for build images section add --critic PassCritic * Update evaluation command in README add more update on commands * Fix formatting in README for evaluation command * Change critic option to 'pass' and update evaluation command Updated the critic option to be case-insensitive and added additional parameters for evaluation.
KTanmay1
pushed a commit
to Ethara-Ai/milo-bench
that referenced
this pull request
Mar 3, 2026
* Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Clean up resume logic and improve code clarity - Simplify comments and logging messages - Use more concise intersection operator (&) - Remove redundant logging in _prepare_instances_for_resume - Revert --split default to keep it required (minimal change) Co-authored-by: openhands <openhands@all-hands.dev> * Fix benchmark resumption issue with --select parameter - Fixed _get_resume_start_attempt() to return next attempt (attempt + 1) instead of last completed attempt - Added _prepare_instances_for_resume() method to get unfiltered instances for proper intersection logic - Resume now correctly detects and continues from the next attempt when using --select parameter Co-authored-by: openhands <openhands@all-hands.dev> * Removed duplicated code * Fix resume logic finishes incomplete last attempt before continuing * Revert "Add --critic (OpenHands#58)" This reverts commit da8976f. * Revert "Implement GAIA benchmark (OpenHands#54)" This reverts commit ade2f62. * bring gaia back * revert pyproject --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Xingyao Wang <xingyao@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least
--critic PassCriticis required inbenchmarks/swe_bench/build_images.py