feat: add proxy cost summary to cost report#606
Merged
simonrosenberg merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
all-hands-bot
approved these changes
Apr 2, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean implementation that follows the existing cost-tracking pattern, maintains backward compatibility, and includes tests. The parallel structure (separate proxy_cost_summary vs mixing into summary) is the right call—it keeps the distinction between accumulated_cost and proxy_cost clear.
KEY INSIGHT: Pragmatic extension of existing reporting logic without breaking the "no double-count" semantics. Ship it.
f5d3298 to
7d04ea2
Compare
7d04ea2 to
605266b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_result.proxy_costvalues when generatingcost_report.jsonlproxy_cost_summaryfield to the report JSONsummary.total_costbehavior unchangedOutput shape
The generated
cost_report.jsonlnow includes:Scope
This PR only changes report generation. It does not add
proxy_costto per-instance outputs by itself.Testing
pytest -q tests/test_report_costs.pypython3 -m py_compile benchmarks/utils/report_costs.pyCloses #603