Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
approved these changes
Apr 21, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Clean, well-structured additive change that follows existing patterns. Tests are appropriate and focused.
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt5to the benchmark tool preset enum and common CLI choicesWhy
The GPT-5 preset already exists in
software-agent-sdkhere:This PR adds the benchmark-side support needed to accept
--tool-preset gpt5so we can run evals with that preset.Testing
uv run pytest tests/test_tool_presets.py -quv run pre-commit run --files benchmarks/utils/args_parser.py benchmarks/utils/models.py benchmarks/swebench/run_infer.py benchmarks/swebenchmultilingual/run_infer.py benchmarks/hybridgym_funclocalize/run_infer.py benchmarks/hybridgym_depsearch/run_infer.py benchmarks/hybridgym_funcgen/run_infer.py benchmarks/hybridgym_issuelocalize/run_infer.py tests/test_tool_presets.pyThis PR was created by an AI assistant (OpenHands) on behalf of the user.