Revert "Upgrade LiteLLM to 1.84.1 (#709)"#729
Draft
juanmichelini wants to merge 1 commit into
Draft
Conversation
This reverts commit 27cb0cf. The litellm 1.84.1 upgrade correlates with a regression for `litellm_proxy/anthropic/claude-opus-4-8`: every conversation now fails with litellm.UnsupportedParamsError: anthropic does not support parameters: ['reasoning_effort', 'thinking'], for model=claude-opus-4-8 Smoke run 26608744731 (before the upgrade reached the proxy) succeeded 1/1; smoke run 26618647016 and full run 26609410334 (after) errored on every instance, leaving `output.jsonl=0` and all completed instances in `output_errors.jsonl`. Reverting in benchmarks restores the prior pinned litellm in the inference runtime; the proxy will also need to be brought back in line (or have `litellm_settings.drop_params: true` configured) for the fix to take effect end-to-end. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #709 (commit
27cb0cf0).Why
The litellm
1.84.1upgrade correlates with a regression forlitellm_proxy/anthropic/claude-opus-4-8. Every conversation against that model now fails with:This bubbles up as
code: LLMBadRequestErroron the conversation, the worker logsRemote conversation ended with error, the instance is retried 4×, all 4 fail, and the result lands inoutput_errors.jsonlwithpatch_len=0. Becauseget_default_on_result_writerroutes errored results away fromoutput.jsonl, the eval-monitor dashboard shows0%critic acceptance even though the critic never actually evaluated anything.Evidence
Same SDK commit (
45697f5) and identical LLM payload (drop_params: true,reasoning_effort: high,extended_thinking_budget: 200000) on both sides of the boundary:2660874473126609410334output.jsonl=0)26618647016UnsupportedParamsError× 4 attemptsThe failing conversation event (
conversations/scikit-learn__scikit-learn-13439/events/event-00005-*.jsonin26618647016/results.tar.gz) contains the proxy'sLLMBadRequestErrorverbatim.Caveats
drop_params: true) is already set on the SDK side. Withlitellm_proxy/...as the provider, the SDK forwardsreasoning_effort/thinkingto the proxy as OpenAI params, and the proxy's litellm is the one rejecting them. So a complete fix also needslitellm_settings.drop_params: true(or an equivalent per-model config) onllm-proxy.eval.all-hands.dev.Suggested follow-ups
drop_params: true(or register a model entry foranthropic/claude-opus-4-8that explicitly acceptsthinking/reasoning_effort).output.jsonl == 0andoutput_errors.jsonl > 0, surface "all completed instances errored" instead of "0% critic acceptance" so this failure mode isn't mistaken for a critic problem.This PR was opened by an AI agent (OpenHands) on behalf of @juanmichelini.
@juanmichelini can click here to continue refining the PR