chore: remove PR review GitHub Actions workflow#526
Conversation
Remove `pr-review-by-openhands.yml`, `pr-review-evaluation.yml` — PR review is now handled via OpenHands Cloud automation. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable approach - Clean deletion of redundant workflows, but missing critical verification
[CRITICAL ISSUES]
-
Missing Evidence: No proof that OpenHands Cloud automation is configured and working. Before removing these workflows, provide:
- Link to the Cloud automation configuration
- Example of Cloud automation successfully reviewing a recent PR in this repository
- Confirmation that all necessary triggers are set up
-
Behavioral Change - Trigger Gap: The old workflow auto-triggered on
openedfor non-draft PRs from established contributors. The PR description lists Cloud automation triggers asready_for_review,review_requested, andlabeled- but doesn't mentionopened. This means newly opened PRs won't get automatic review anymore. Is this intentional? If so, call it out explicitly in the PR description. -
Documentation Inconsistency: The file
openhands/usage/use-cases/code-review.mdxstill documents and recommends the GitHub Actions workflow approach with example YAML configs. If Cloud automation is now the preferred approach for the docs repo itself, this documentation should be updated to reflect that (or at least note that the docs repo uses Cloud automation).
[IMPROVEMENT OPPORTUNITIES]
- Evaluation Workflow: The
pr-review-evaluation.ymlworkflow provided feedback on review quality. Is this functionality replaced in Cloud automation, or is it being intentionally removed? Worth documenting either way.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟡 MEDIUM (potentially 🔴 HIGH if Cloud automation isn't ready)
This PR removes critical automation infrastructure. Risk is MEDIUM if Cloud automation is fully configured and tested, but HIGH if:
- Cloud automation isn't actually set up for this repository
- The trigger gap causes newly opened PRs to be missed
- There's an unexpected gap in review coverage during the transition
Recommendation: Do not merge until Cloud automation is verified working in this repository. Test by opening a test PR and confirming Cloud automation reviews it.
VERDICT:
❌ Needs verification: Deletion is clean, but requires evidence that the replacement is working and clarification on the behavioral change.
KEY INSIGHT:
Removing automation before confirming the replacement works risks breaking PR review coverage. The missing opened trigger represents a significant behavioral change that should be explicitly acknowledged.
Improve this review? If any feedback above seems incorrect or irrelevant to this repository, you can teach the reviewer to do better:
- Add a
.agents/skills/custom-codereview-guide.mdfile to your branch (or edit it if one already exists) with the/codereviewtrigger and the context the reviewer is missing (e.g., "Security concerns about X do not apply here because Y"). See the customization docs for the required frontmatter format.- Re-request a review - the reviewer reads guidelines from the PR branch, so your changes take effect immediately.
- When your PR is merged, the guideline file goes through normal code review by repository maintainers.
Resolve with AI? Install the iterate skill in your agent and run
/iterateto automatically drive this PR through CI, review, and QA until it's merge-ready.Was this review helpful? React with 👍 or 👎 to give feedback.
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/docs/actions/runs/26521635714
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Cloud automation for pr review is ready
Summary
Removes the PR review GitHub Actions workflow(s) as code review is now handled via OpenHands Cloud automation.
Changes
.github/workflows/pr-review-by-openhands.yml.github/workflows/pr-review-evaluation.ymlWhy
PR review functionality has been migrated to OpenHands Cloud automation, which triggers on:
ready_for_review(established contributors)review_requested(whenall-hands-botis requested as reviewer)labeled(withreview-thislabel)The GitHub Actions workflow is redundant and can be removed.
This PR was created by an AI agent (OpenHands) on behalf of the user.