Skip to content

chore: remove PR review GitHub Actions workflow#526

Merged
malhotra5 merged 1 commit into
mainfrom
remove-pr-review-workflow
May 27, 2026
Merged

chore: remove PR review GitHub Actions workflow#526
malhotra5 merged 1 commit into
mainfrom
remove-pr-review-workflow

Conversation

@xingyaoww
Copy link
Copy Markdown
Member

Summary

Removes the PR review GitHub Actions workflow(s) as code review is now handled via OpenHands Cloud automation.

Changes

  • Deleted .github/workflows/pr-review-by-openhands.yml
  • Deleted .github/workflows/pr-review-evaluation.yml

Why

PR review functionality has been migrated to OpenHands Cloud automation, which triggers on:

  • ready_for_review (established contributors)
  • review_requested (when all-hands-bot is requested as reviewer)
  • labeled (with review-this label)

The GitHub Actions workflow is redundant and can be removed.

This PR was created by an AI agent (OpenHands) on behalf of the user.

Remove `pr-review-by-openhands.yml`, `pr-review-evaluation.yml` — PR review is now handled
via OpenHands Cloud automation.

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Copy Markdown
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Acceptable approach - Clean deletion of redundant workflows, but missing critical verification

[CRITICAL ISSUES]

  1. Missing Evidence: No proof that OpenHands Cloud automation is configured and working. Before removing these workflows, provide:

    • Link to the Cloud automation configuration
    • Example of Cloud automation successfully reviewing a recent PR in this repository
    • Confirmation that all necessary triggers are set up
  2. Behavioral Change - Trigger Gap: The old workflow auto-triggered on opened for non-draft PRs from established contributors. The PR description lists Cloud automation triggers as ready_for_review, review_requested, and labeled - but doesn't mention opened. This means newly opened PRs won't get automatic review anymore. Is this intentional? If so, call it out explicitly in the PR description.

  3. Documentation Inconsistency: The file openhands/usage/use-cases/code-review.mdx still documents and recommends the GitHub Actions workflow approach with example YAML configs. If Cloud automation is now the preferred approach for the docs repo itself, this documentation should be updated to reflect that (or at least note that the docs repo uses Cloud automation).

[IMPROVEMENT OPPORTUNITIES]

  • Evaluation Workflow: The pr-review-evaluation.yml workflow provided feedback on review quality. Is this functionality replaced in Cloud automation, or is it being intentionally removed? Worth documenting either way.

[RISK ASSESSMENT]

  • [Overall PR] ⚠️ Risk Assessment: 🟡 MEDIUM (potentially 🔴 HIGH if Cloud automation isn't ready)

This PR removes critical automation infrastructure. Risk is MEDIUM if Cloud automation is fully configured and tested, but HIGH if:

  • Cloud automation isn't actually set up for this repository
  • The trigger gap causes newly opened PRs to be missed
  • There's an unexpected gap in review coverage during the transition

Recommendation: Do not merge until Cloud automation is verified working in this repository. Test by opening a test PR and confirming Cloud automation reviews it.

VERDICT:

Needs verification: Deletion is clean, but requires evidence that the replacement is working and clarification on the behavioral change.

KEY INSIGHT:

Removing automation before confirming the replacement works risks breaking PR review coverage. The missing opened trigger represents a significant behavioral change that should be explicitly acknowledged.


Improve this review? If any feedback above seems incorrect or irrelevant to this repository, you can teach the reviewer to do better:

  1. Add a .agents/skills/custom-codereview-guide.md file to your branch (or edit it if one already exists) with the /codereview trigger and the context the reviewer is missing (e.g., "Security concerns about X do not apply here because Y"). See the customization docs for the required frontmatter format.
  2. Re-request a review - the reviewer reads guidelines from the PR branch, so your changes take effect immediately.
  3. When your PR is merged, the guideline file goes through normal code review by repository maintainers.

Resolve with AI? Install the iterate skill in your agent and run /iterate to automatically drive this PR through CI, review, and QA until it's merge-ready.

Was this review helpful? React with 👍 or 👎 to give feedback.


Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/docs/actions/runs/26521635714

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 27, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
all-hands-ai 🟢 Ready View Preview May 27, 2026, 3:45 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Copy link
Copy Markdown
Member

@malhotra5 malhotra5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malhotra5 malhotra5 enabled auto-merge (squash) May 27, 2026 15:49
@malhotra5 malhotra5 dismissed all-hands-bot’s stale review May 27, 2026 15:49

Cloud automation for pr review is ready

@malhotra5 malhotra5 merged commit 26c940f into main May 27, 2026
6 checks passed
@malhotra5 malhotra5 deleted the remove-pr-review-workflow branch May 27, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants