feat: add agent-creator skill#122
Conversation
VascoSch92
left a comment
There was a problem hiding this comment.
There are a few points that I believe are missing:
-
Documentation & Context: Currently, the agent doesn't know what a "file-based agent" is. We should provide a link to the documentation so the agent can create sub-agents using verified, state-of-the-art methods.
-
The Interview Process: The interview flow is great, but there are a few more questions we should ask the user. For instance: "Do you want this to be a project agent or a user agent?" and "What should the permissions be?" These are crucial details, and there may be others we should consider.
-
Lifecycle & State: When the agent creates the sub-agent's .md file, do we need to restart the conversation for it to become available? Have you tested this? I suspect a restart might be necessary.
-
Demo: Could you record a short video of you triggering the skill to show how it works? It would be helpful to see exactly what to expect.
I think we’re on the right track! We just have a few important things left to address.
Thank you very much! :-)
- Interview-based workflow to collect agent requirements - Generates valid OpenHands file-based agent .md files - Follows official OpenHands SDK spec (agent-file-based format) - Includes fallback spec in references/fallback.md for offline use - Auto-generated Claude Code command via sync_extensions.py
c46c470 to
4b3d798
Compare
|
Thank you for the detailed feedback! Here is how I addressed each point: Documentation & Context It extracts only the three most relevant sections (Agent File Format, Interview Process
Lifecycle & State
Skill name Demo |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solid feature that solves a real problem, but has minor issues to address.
Taste Rating: The skill provides value but the workflow is overly rigid. A few typos and missing test coverage.
|
Hey @Baduc81 thank you very much. The video is amazing :-) Good skill, clear interview workflow and the right guardrails. A few super small things:
@enyst WDYT? |
Code Review Summary🟡 AcceptableThe [IMPROVEMENT OPPORTUNITIES]Workflow Flexibility (Lines 41-44, 58-59)
Minor Issues
[TESTING GAPS]
[RISK ASSESSMENT]
Risk Factors:
Recommendation: Safe to merge after addressing typos. The fallback mechanism provides good resilience against external dependency failures. Consider adding basic validation tests in a follow-up PR. VERDICT✅ Worth merging: Core design is sound, minor improvements suggested. The interview workflow is well thought out, though it could be more flexible for experienced users. KEY INSIGHTThis skill demonstrates good defensive design with its fallback mechanism and structured interview process. The trade-off between rigid consistency vs. user flexibility leans toward consistency—which may be the right choice for ensuring quality agent generation, but consider allowing power users to short-circuit the process when they provide comprehensive upfront information. This review was created by an AI agent (OpenHands) on behalf of all-hands-bot. |
- fix typo in interview rules - add missing frontmatter fields to fallback.md (max_iteration_per_run, hooks, profile_store_dir) - add trailing newlines to markdown files
|
Thanks for the feedback! I've addressed all the points:
Let me know if anything else needs improvement. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solid feature that solves a real problem with good documentation. The interview-driven workflow is well-structured, though the tone could be less authoritarian.
enyst
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you so much for this!
I think maybe we can take this PR in, and we can always iterate in live use?
|
🚀 Released in v0.1.0. |
|
🚀 Released in v0.2.0. |
Summary
Adds a new
agent-creatorskill that guides users through creatingfile-based sub-agents via a structured interview workflow.
What this skill does
permission mode, scope, etc.) one at a time
.mdfile following the OpenHands file-basedagent specification
Changes
skills/agent-creator/SKILL.md— skill definition and interview workflowskills/agent-creator/README.md— human-facing documentationskills/agent-creator/references/fallback.md— offline fallback specskills/agent-creator/commands/agent-creator.md— auto-generatedmarketplaces/openhands-extensions.json— registered in marketplaceTesting
uv run pytest -qpassesuv run python scripts/sync_extensions.py --checkpassesDemo