Add code-simplifier skill with three-aspect review#211
Conversation
Migrated and adapted from the Claude Plugins Official code-simplifier plugin. Split into three focused review dimensions (code reuse, code quality, efficiency) with sub-agent delegation support and AGENTS.md integration. Co-authored-by: openhands <openhands@all-hands.dev>
…GENTS.md Co-authored-by: openhands <openhands@all-hands.dev>
Replace three keyword triggers (simplify, refine, cleanup) with a single /simplify slash command via the commands/ directory approach, per repository conventions. Co-authored-by: openhands <openhands@all-hands.dev>
Let sync_extensions.py auto-generate the commands/simplify.md file from the trigger definition. Co-authored-by: openhands <openhands@all-hands.dev>
Required by test_skill_plugin_loading.py for Codex compatibility. Co-authored-by: openhands <openhands@all-hands.dev>
Generated by sync_extensions.py for Codex/Claude compatibility. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Well-designed skill with good progressive disclosure structure, but uses deprecated trigger convention.
[IMPROVEMENT OPPORTUNITIES]
- Trigger format uses deprecated slash convention instead of keywords
- Scope specification could be more explicit for user clarity
[RISK ASSESSMENT]
New skill addition with no changes to existing code. Well-structured progressive disclosure, properly registered in marketplace, follows repository conventions (except trigger format). Limited blast radius - only affects users who invoke this specific skill.
VERDICT: ✅ Worth merging after addressing trigger convention
KEY INSIGHT: The three-aspect split (reuse, quality, efficiency) with separate reference documents is a pragmatic improvement over monolithic review - each dimension has clear, actionable criteria without forcing special-case handling.
Co-authored-by: openhands <openhands@all-hands.dev>
|
Addressed feedback in 5d8be69. Ready for another look. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Well-designed skill addition with clear structure, pragmatic philosophy, and proper progressive disclosure.
[RISK ASSESSMENT]
New skill addition with no changes to existing code. Well-structured progressive disclosure with three focused review dimensions (reuse, quality, efficiency), properly registered in marketplace, follows repository conventions including the new punctuation style. Previous review feedback has been addressed.
VERDICT:
✅ Worth merging: Elegant solution that addresses a real need without over-engineering.
KEY INSIGHT:
The three-aspect breakdown with separate reference files demonstrates good taste in progressive disclosure - simple enough to understand quickly, detailed enough to be useful in practice.
Why
The code-simplifier plugin from the Claude Plugins Official repository provides useful code simplification capabilities, but it is a single monolithic pass and references Claude-specific conventions (
CLAUDE.md). This PR migrates and adapts it for OpenHands as a proper skill with progressive disclosure, split into three focused review dimensions.Summary
code-simplifierskill that analyzes recently modified code across three dimensions: code reuse, code quality, and efficiencyreferences/code-reuse-review.md,references/code-quality-review.md,references/efficiency-review.md) for progressive disclosureCLAUDE.mdreferences replaced withAGENTS.mdfor OpenHands compatibilitymarketplaces/openhands-extensions.jsonand README catalog updated via sync scriptHow to Test
ls -R skills/code-simplifier/pip install pyyaml && python scripts/sync_extensions.py --checkgrep -A 8 'code-simplifier' marketplaces/openhands-extensions.jsonAGENTS.md[REUSE],[QUALITY],[EFFICIENCY])Notes
simplify,refine,cleanup) rather than slash commandsThis PR was created by an AI agent (OpenHands) on behalf of the user.
@xingyaoww can click here to continue refining the PR