This repository was archived by the owner on May 15, 2026. It is now read-only.
Fix ASCII encoding issue when updating files with non-ASCII characters#116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with file encoding detection that causes errors when trying to add non-ASCII characters (like Chinese text) to files that were initially created with only ASCII content.
Related Issue
This issue was reported in OpenHands issue #8209.
Motivation and Context
When a file is initially created with only ASCII characters, its encoding is detected as 'ascii'. However, when trying to add non-ASCII characters to this file later, the operation fails with a UnicodeEncodeError because the 'ascii' encoding can't handle these characters.
Error message:
This fix ensures that files initially containing only ASCII characters can later accept non-ASCII content (such as Chinese, Japanese, or other Unicode characters).
How Has This Been Tested?
Added a test case in
tests/test_encoding.pythat verifies ASCII files are detected as UTF-8, ensuring they can handle non-ASCII characters when edited later.Does this PR introduce a breaking change?
No, this PR does not introduce a breaking change. It maintains backward compatibility while fixing the encoding issue.