Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Fix issue #140: Suppress pydub warnings when ffmpeg is not available#141

Merged
ryanhoangt merged 3 commits into
mainfrom
fix-pydub-warning
Jun 22, 2025
Merged

Fix issue #140: Suppress pydub warnings when ffmpeg is not available#141
ryanhoangt merged 3 commits into
mainfrom
fix-pydub-warning

Conversation

@neubig
Copy link
Copy Markdown
Contributor

@neubig neubig commented Jun 21, 2025

This PR fixes issue #140 by suppressing pydub warnings when ffmpeg is not available.

Changes:

  1. Added conditional import for pydub that checks if ffmpeg or avconv is available
  2. Modified Mp3Converter to check for pydub availability before attempting to use it
  3. Added unit tests to verify the fix

Testing:

  • Added unit tests that verify the Mp3Converter handles the case when pydub is not available or ffmpeg is not installed
  • All unit tests pass

Fixes #140

@neubig can click here to continue refining the PR

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Jun 21, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Lint

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #141

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@neubig neubig self-assigned this Jun 21, 2025
@neubig neubig marked this pull request as ready for review June 21, 2025 15:17
@neubig neubig removed their assignment Jun 21, 2025
@neubig
Copy link
Copy Markdown
Contributor Author

neubig commented Jun 21, 2025

LGTM need a second review

@neubig neubig self-assigned this Jun 21, 2025
@neubig neubig removed their assignment Jun 21, 2025
Copy link
Copy Markdown
Contributor

@ryanhoangt ryanhoangt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I test locally and this seems to work!

@ryanhoangt ryanhoangt merged commit 0761874 into main Jun 22, 2025
3 checks passed
@ryanhoangt ryanhoangt deleted the fix-pydub-warning branch June 22, 2025 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress pydub if necessary tools are not available

3 participants