Apply code formatting and implement downgrade warnings#322
Merged
rainxchzed merged 4 commits intomainfrom Mar 13, 2026
Merged
Conversation
- Implement `DowngradeWarning` logic in the details presentation layer to alert users when attempting to install a version older than the one currently installed. - Add project-wide code reformatting across all modules, standardizing indentation, trailing commas, and import organization. - Enhance the search feature with clipboard link detection, introducing a `ClipboardBanner` and `DetectedLinksSection`. - Standardize repository interfaces and domain models in the `core` modules with consistent spacing and structure. - Refine the "Update All" progress tracking and app state management in `AppsViewModel`. - Improve the GitHub device authentication flow with better countdown logic and specific error recovery hints. - Update UI components across features to utilize `LocalTopbarLiquidState` and `LocalHomeTopBarLiquid` for consistent expressive styling.
Contributor
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
- Create `KtlintConventionPlugin` to configure ktlint with version 1.8.0, console output enabled, and exclusion filters for generated/build directories. - Register the new `ktlint` convention plugin in `build-logic/convention/build.gradle.kts`. - Add a task dependency to automatically install the ktlint format git pre-commit hook during the `preBuild` stage. - Apply the ktlint convention plugin to multiple existing plugins: `CmpFeature`, `CmpLibrary`, `KmpLibrary`, `AndroidApplication`, `AndroidApplicationCompose`, and `CmpApplication`. - Update `libs.versions.toml` to include the `ktlint-gradle` plugin dependency.
- Add `.editorconfig` with specific rules for ktlint, including disabling wildcard import checks and ignoring naming conventions for `@Composable` functions. - Centralize ktlint task execution by adding a `subprojects` block in the root `build.gradle.kts` that makes build and compilation tasks depend on `ktlintFormat`. - Remove manual `ktlint` plugin application from individual convention plugins (`CmpFeature`, `CmpLibrary`, `KmpLibrary`, `AndroidApplication`, `CmpApplication`). - Update `KtlintConventionPlugin` to exclude generated files and schemas, and configure PLAIN and HTML reporters. - Remove the automatic git pre-commit hook task dependency from `build-logic`. - Add `slf4j-simple` dependency to `libs.versions.toml`.
- Add `libs.slf4j.simple` to the `desktopMain` source set in `composeApp/build.gradle.kts` to provide an SLF4J logger implementation for desktop targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DowngradeWarninglogic in the details presentation layer to alert users when attempting to install a version older than the one currently installed.ClipboardBannerandDetectedLinksSection.coremodules with consistent spacing and structure.AppsViewModel.LocalTopbarLiquidStateandLocalHomeTopBarLiquidfor consistent expressive styling.