Skip to content

ci: fail "Print openidm logs" step on errors/exceptions in OpenIDM logs#175

Merged
vharseko merged 2 commits into
OpenIdentityPlatform:masterfrom
vharseko:ci-fail
May 14, 2026
Merged

ci: fail "Print openidm logs" step on errors/exceptions in OpenIDM logs#175
vharseko merged 2 commits into
OpenIdentityPlatform:masterfrom
vharseko:ci-fail

Conversation

@vharseko
Copy link
Copy Markdown
Member

Summary

Enhances the Print openidm logs step in the ui-smoke-tests job to not only print log files but also actively scan them for error conditions and fail the step when problems are detected.

Motivation

Previously, the Print openidm logs step only dumped the contents of openidm/logs/* for debugging purposes and always succeeded. As a result, runtime errors or unhandled exceptions logged by OpenIDM during UI smoke tests could go unnoticed if the Playwright tests themselves happened to pass. We need the CI to surface such issues by failing the build.

Changes

  • After printing all log files in openidm/logs, the step now scans every file for the patterns: ERROR, SEVERE, Exception, Throwable.
  • For each file containing matches, the matching lines (with line numbers) are reported.
  • If any matches are found, the step exits with a non-zero status, failing the job.
  • If the openidm/logs directory does not exist, the step exits cleanly (preserves previous behavior).
  • The step still runs under if: ${{ always() }}, so logs are printed and validated even when earlier steps fail.

Behavior

  • ✅ No errors/exceptions in logs → step succeeds.
  • ❌ Any ERROR / SEVERE / Exception / Throwable in logs → step prints the offending lines and fails.

Risk / Impact

  • Limited to the ui-smoke-tests job in .github/workflows/build.yml.
  • May expose pre-existing log noise that was previously ignored; such cases should be triaged and fixed (or the patterns refined) on a per-case basis.

@vharseko vharseko requested a review from maximthomas May 13, 2026 09:12
@vharseko vharseko merged commit bf4c19e into OpenIdentityPlatform:master May 14, 2026
3 of 15 checks passed
@vharseko vharseko deleted the ci-fail branch May 14, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants