ci: fail "Print openidm logs" step on errors/exceptions in OpenIDM logs#175
Merged
Conversation
maximthomas
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
Print openidm logsstep in theui-smoke-testsjob to not only print log files but also actively scan them for error conditions and fail the step when problems are detected.Motivation
Previously, the
Print openidm logsstep only dumped the contents ofopenidm/logs/*for debugging purposes and always succeeded. As a result, runtime errors or unhandled exceptions logged by OpenIDM during UI smoke tests could go unnoticed if the Playwright tests themselves happened to pass. We need the CI to surface such issues by failing the build.Changes
openidm/logs, the step now scans every file for the patterns:ERROR,SEVERE,Exception,Throwable.openidm/logsdirectory does not exist, the step exits cleanly (preserves previous behavior).if: ${{ always() }}, so logs are printed and validated even when earlier steps fail.Behavior
ERROR/SEVERE/Exception/Throwablein logs → step prints the offending lines and fails.Risk / Impact
ui-smoke-testsjob in.github/workflows/build.yml.